Changeset 31335

Timestamp:

Apr 21, 2011, 11:35:12 AM (15 years ago)

Author:

bills

Message:

integate bug fix from Gene

Location:

tags/ipp-20110406/psModules

Files:

• . (modified) (1 prop)
• src/objects/pmFootprintAssignPeaks.c (modified) (2 diffs)
• src/objects/pmFootprintIDs.c (modified) (1 diff)

tags/ipp-20110406/psModules/src/objects/pmFootprintAssignPeaks.c

@@ -35 +35 @@
     assert (peaks->n == 0 || psMemCheckPeak(peaks->data[0]));
     
-    if (footprints->n == 0) {
-        if (peaks->n > 0) {
-            return psError(PS_ERR_BAD_PARAMETER_SIZE, true, "Your list of footprints is empty");
-        }
+    if ((footprints->n == 0) && (peaks->n == 0)) {
         return PS_ERR_NONE;
     }
+
     /*
      * Create an image filled with the object IDs, and use it to assign pmPeaks to the
@@ -59 +57 @@
         
         if (ids) { assert (x >= 0 && x < numCols && y >= 0 && y < numRows);}
-        int id = ids ? ids->data.S32[y][x - col0] : 0;
-        // XXX I think the '[x - col0]' above is just wrong (should be [x], but never gets triggerd.
+        int id = ids ? ids->data.S32[y][x] : 0;
 
         if (id == 0) {                  // peak isn't in a footprint, so make one for it

tags/ipp-20110406/psModules/src/objects/pmFootprintIDs.c

@@ -66 +66 @@
 
    if (footprints->n == 0) {
-       // XXX this was an error, but is an allowed condition -- NULL returned image means no footprints for any peaks
-       // psError(PS_ERR_BAD_PARAMETER_SIZE, true, "You didn't provide any footprints");
        return NULL;
    }