Changeset 30641

Timestamp:

Feb 15, 2011, 3:55:42 PM (15 years ago)

Author:

eugene

Message:

modified following Eddies suggestion to result in the variance expected for the observed sky value

File:

• tags/ipp-20101215/ppImage/src/ppImageAddNoise.c (modified) (2 diffs)

tags/ipp-20101215/ppImage/src/ppImageAddNoise.c

@@ -20 +20 @@
 
   // grizy variances to add to turn MD exposure -> 3pi, calculated from the DRM 
-  static float add_sigmas[] = {NAN, 13.39, 23.79, 75.25, 110.19, 128.84};
+  // static float add_sigmas[] = {NAN, 13.39, 23.79, 75.25, 110.19, 128.84};
   
   // Target Exposure times for 3pi in grizy
   static float expTimes3Pi[] = {NAN, 43.0, 40.0, 45.0, 30.0, 30.0}; 
-  float expTime   = psMetadataLookupF32(NULL, fpa->concepts, "FPA.EXPOSURE"); // Exposure time for image
+  float expTime = psMetadataLookupF32(NULL, fpa->concepts, "FPA.EXPOSURE"); // Exposure time for image
 
   // Something to choose the band, g,r,i,z,y = 0,1,2,3,4 respectively
@@ -60 +60 @@
 
   // Add in appropriate variance, and scale the image 
-  float expTimeScaling =  expTime/expTimes3Pi[band];
-  // XXX why was this not used? float expTimeScalingSqd = PS_SQR(expTimeScaling);
+  float rho  =  expTime/expTimes3Pi[band];
+  float rho2 = PS_SQR(rho);
 
   psRandom *rng = psRandomAlloc(PS_RANDOM_TAUS); // Random number generator
 
+  psStats *stats = psStatsAlloc (PS_STAT_SAMPLE_MEDIAN);
+  stats->nSubsample = 10000;
+
+  psImageBackground(stats, NULL, inReadout->image, inReadout->mask, 0xffff, rng);
+  double MSKY_MN = stats->sampleMedian;
+
+  // set GAIN and RDNOISE to nominal values:
+  double GAIN = 1.0; // electrons / DN
+  double RDNOISE = 6.0; // electrons (== DN)
+
+  double add_sigma = sqrt((MSKY_MN/GAIN)*(rho - 1.0) + PS_SQR(RDNOISE)*(rho2 - 1.0));
+
   for (int iy = 0; iy < image->numRows; iy++){
     for (int ix = 0; ix < image->numCols; ix++){
-      image->data.F32[iy][ix] += ppImageRandomGaussian(rng, 0.0, add_sigmas[band]);
-      image->data.F32[iy][ix] /= expTimeScaling;
-      variance->data.F32[iy][ix] += PS_SQR(add_sigmas[band]);
-      variance->data.F32[iy][ix] /= expTimeScaling;
+      image->data.F32[iy][ix] += ppImageRandomGaussian(rng, 0.0, add_sigma);
+      image->data.F32[iy][ix] /= rho;
+      variance->data.F32[iy][ix] += PS_SQR(add_sigma);
+      variance->data.F32[iy][ix] /= rho2;
     }
   }