Changeset 30403

Timestamp:

Jan 28, 2011, 8:32:33 AM (15 years ago)

Author:

bills

Message:

fix error when no magicRuns are pending

File:

• tags/ipp-20101215/ippTools/src/magictool.c (modified) (2 diffs)

tags/ipp-20101215/ippTools/src/magictool.c

@@ -886 +886 @@
         return false;
     }
-    psArray *output = NULL;
-    if (psArrayLength(magicRuns)) {
-        output = psArrayAllocEmpty(100);
-
+    if (!psArrayLength(magicRuns)) {
+        // no magicRuns pending. Nothing to do
+        psTrace("magictool", PS_LOG_INFO, "no rows found");
+        psFree(magicRuns);
+        return true;
+    }
+
+    psArray *output = psArrayAllocEmpty(100);
+    // the following is indented because I removed a conditional and I decided not to shift over
         query = pxDataGet("magictool_toprocess_tree.sql");
         if (!query) {
@@ -989 +994 @@
             }
         }
-    }
+    // the above code is indented because I removed a conditional block and I decided not to shift it over
 
     // look for "inputs" that need to processed