Changeset 30274

Timestamp:

Jan 13, 2011, 1:08:55 PM (15 years ago)

Author:

rhenders

Message:

Added czar-database clean-up interval to config file, and changed relevant code in czartool (interval is 30 minutes)

Location:

trunk/tools

Files:

• czarclean.pl (modified) (4 diffs)
• czarpoll.pl (modified) (2 diffs)
• czartool/Config.pm (modified) (2 diffs)
• czartool/czarconfig.xml (modified) (1 diff)

trunk/tools/czarclean.pl

@@ -6 +6 @@
 
 # local classes
+use czartool::Config;
 use czartool::CzarDb;
 
 my $czarDbName = undef;
-my $from = undef;
-my $to = undef;
+my $begin = undef;
+my $end = undef;
 my $interval = undef;
 my $verbose = undef;
 my $optimize = undef;
+my $config = new czartool::Config();
 
 GetOptions (
         "dbname|d=s" => \$czarDbName,
         "interval|i=s" => \$interval,
-        "from|f=s" => \$from,
-        "to|t=s" => \$to,
+        "begin|b=s" => \$begin,
+        "end|e=s" => \$end,
         "optimize|o" => \$optimize,
         "verbose|v" => \$verbose,
@@ -32 +34 @@
     print "* UNKNKOWN: option                          @ARGV\n";
 }
-if (!$from) {
+if (!$begin) {
     $quit=1;
-    print "* REQUIRED: choose a from date                 -b <datetime>\n";
+    print "* REQUIRED: choose a begin date                -b <datetime>\n";
 }
-if (!$to) {
-    if($from) {$to=$from;} else {$to="NULL";}
-    print "* OPTIONAL: choose a to date                   -e <datetime>                   (default=$to)\n";
+if (!$end) {
+    if($begin) {$end=$begin;} else {$end="NULL";}
+    print "* OPTIONAL: choose an end date date            -e <datetime>                   (default=$end)\n";
 }
 if (!$czarDbName) {
@@ -45 +47 @@
 }
 if (!$interval) {
-    $interval = "30 MINUTE";
-    print "* OPTIONAL: choose time interval               -i <'30 MINUTE'|'1 hour'|etc>   (default=$interval)\n";
+    print "* OPTIONAL: choose time interval               -i <'30 MINUTE'|'1 hour'|etc>   (default=".$config->getCzarCleanupInterval().")\n";
 }
 if (!$optimize) {
     $optimize = 0;
-    print "* OPTIONAL: optimize database after cleanup    -o <'30 MINUTE'|'1 hour'|etc>   (default=$interval)\n";
+    print "* OPTIONAL: optimize database after cleanup    -o                              (default=$optimize)\n";
 }
 print "*\n*******************************************************************************\n";
@@ -56 +57 @@
 if ($quit) { exit; }
 
-
-my $save_temps = 0;
-
-
-my $czarDb = new czartool::CzarDb($czarDbName, "ippdb01", "ipp", "ipp", 0, $save_temps); # TODO last arg here is save_temps, should get as arg
+my $czarDb = $config->getCzarDbInstance();
 
 my $labels = undef;
 
 
-$czarDb->cleanupDateRange($from, $to, $interval);
+$czarDb->cleanupDateRange($begin, $end, $config->getCzarCleanupInterval());
 if ($optimize) {$czarDb->optimize();}

trunk/tools/czarpoll.pl

@@ -139 +139 @@
                 # create metrics for last 24 hours
                 print "* Creating metrics for last 24 hours\n";
-                # TODO hardcoded path needs to be in config
                 my $dayMetrics = new czartool::DayMetrics($config, 1, 0, $today); 
                 $dayMetrics->writeHTML();
@@ -149 +148 @@
                 # now cleanup tables from yesterday and optimize
                 print "* New day - performing cleanup\n";
-                $czarDb->cleanupDateRange($yesterday, $yesterday, "30 MINUTE");
+                $czarDb->cleanupDateRange($yesterday, $yesterday, $config->getCzarCleanupInterval());
                 $czarDb->optimize();
                 $lastDayDailyTasks = $yesterday;

trunk/tools/czartool/Config.pm

@@ -61 +61 @@
     $self->{czaruser} = $xc->findvalue('//czardatabase/user');
     $self->{czarpassword} = $xc->findvalue('//czardatabase/password');
+    $self->{czardbcleanupinterval} = $xc->findvalue('//czardatabase/cleanupinterval');
 
     # roboczar
@@ -105 +106 @@
 ###########################################################################
 #
+# Returns the interval used in czarDB cleanup
+#
+###########################################################################
+sub getCzarCleanupInterval {
+    my ($self) = @_;
+    return $self->{czardbcleanupinterval};
+}
+
+###########################################################################
+#
 # Returns the interval after which we consider a server to be down/stopped
 #

trunk/tools/czartool/czarconfig.xml

@@ -25 +25 @@
     <user>ipp</user>
     <password>ipp</password>
+    <cleanupinterval>30 MINUTE</cleanupinterval>
   </czardatabase>