Changeset 30221

Timestamp:

Jan 7, 2011, 2:12:33 PM (15 years ago)

Author:

eugene

Message:

the old code was doing something very silly in an attempt to remove duplicate peaks in a given footprint; I do not understand why it was even trying this: all peaks are only assigned once, so there could not be duplicate peaks in any case

File:

• branches/eam_branches/ipp-20101205/psModules/src/objects/pmFootprintAssignPeaks.c (modified) (4 diffs)

branches/eam_branches/ipp-20101205/psModules/src/objects/pmFootprintAssignPeaks.c

@@ -24 +24 @@
 /*
  * Given a psArray of pmFootprints and another of pmPeaks, assign the peaks to the
- * footprints in which that fall; if they _don't_ fall in a footprint, add a suitable
+ * footprints in which they fall; if they _don't_ fall in a footprint, add a suitable
  * one to the list.
  */
@@ -83 +83 @@
 
         // XXX are we allowed to have peak-less footprints??
-        if (!fp->peaks->n) continue;
+        if (fp->peaks->n == 0) continue;
+        if (fp->peaks->n == 1) continue;
 
         fp->peaks = psArraySort(fp->peaks, pmPeakSortBySN);
+
+        // XXX WHY am I culling duplicates?  how can there be duplicates?
+        continue;
 
         // XXX EAM : the algorithm below should be much faster than using psArrayRemove if
@@ -93 +97 @@
 
         // track the number of good peaks in the footprint
-        int nGood = 1;
+        int lastGood = 0;
 
         // check for duplicates
@@ -100 +104 @@
         // (if sorted list has A, B, A, B ...)
         for (int j = 1; j < fp->peaks->n; j++) { 
-            if (fp->peaks->data[j] == fp->peaks->data[nGood]) {
+            if (fp->peaks->data[j] == fp->peaks->data[lastGood]) {
                 // everything on the array has its own mem reference; free and drop this one
                 psFree (fp->peaks->data[j]);
                 fp->peaks->data[j] = NULL;
             } else {
-                nGood ++;
+                lastGood ++;
             }
         }
+        int nGood = lastGood + 1;
 
         // no deleted peaks, go to next footprint