Changeset 29851

Timestamp:

Nov 26, 2010, 10:47:07 AM (15 years ago)

Author:

eugene

Message:

updates from trunk (non-linearity correction)

Location:

branches/eam_branches/ipp-20101103/ppImage/src

Files:

• ppImage.h (modified) (1 diff)
• ppImageArguments.c (modified) (2 diffs)
• ppImageDefineFile.c (modified) (4 diffs)
• ppImageDetrendFree.c (modified) (2 diffs)
• ppImageDetrendNonLinear.c (modified) (2 diffs)
• ppImageDetrendReadout.c (modified) (3 diffs)
• ppImageLoop.c (modified) (1 diff)
• ppImageOptions.c (modified) (3 diffs)
• ppImageParseCamera.c (modified) (1 diff)

branches/eam_branches/ipp-20101103/ppImage/src/ppImage.h

@@ -155 +155 @@
 bool ppImageDetrendBias(pmReadout *inputReadout, pmReadout *bias, pmReadout *dark, ppImageOptions *options);
 
-bool ppImageDetrendNonLinear(pmReadout *input, ppImageOptions *options);
+//bool ppImageDetrendNonLinear(pmReadout *input, ppImageOptions *options);
+bool ppImageDetrendNonLinear(pmReadout *input, pmFPAview *linearity, pmConfig *config);
 bool ppImageDetrendNonLinearLookup(pmReadout *input, psMetadataItem *dataItem);
 bool ppImageDetrendNonLinearPolynomial(pmReadout *input, psMetadataItem *dataItem);

branches/eam_branches/ipp-20101103/ppImage/src/ppImageArguments.c

@@ -24 +24 @@
     fprintf(stderr, "\t-mask/-masklist: Mask image.\n");
     fprintf(stderr, "\t-fringe/-fringelist: Fringe image and data.\n");
+    fprintf(stderr, "\t-linearity/-linearlist: linearity correction file.\n");
     fprintf(stderr, "\n");
     exit (2);
@@ -120 +121 @@
     pmConfigFileSetsMD (config->arguments, &argc, argv, "MASK", "-mask", "-masklist");
     pmConfigFileSetsMD (config->arguments, &argc, argv, "FRINGE", "-fringe", "-fringelist");
+    pmConfigFileSetsMD (config->arguments, &argc, argv, "LINEARITY", "-linearity", "-linearlist");
 
     // chip selection is used to limit chips to be processed

branches/eam_branches/ipp-20101103/ppImage/src/ppImageDefineFile.c

@@ -15 +15 @@
         file = pmFPAfileDefineFromArgs(&status, config, filerule, argname);
         if (!status) {
-            psError(PS_ERR_UNKNOWN, false, "failed to load file definition");
+            psError(PS_ERR_UNKNOWN, false, "failed to load file definition ARG LIST");
             return false;
         }
@@ -23 +23 @@
         file = pmFPAfileDefineFromRun(&status, NULL, config, filerule);
         if (!status) {
-            psError(PS_ERR_UNKNOWN, false, "failed to load file definition");
+            psError(PS_ERR_UNKNOWN, false, "failed to load file definition RUN");
             return false;
         }
@@ -31 +31 @@
         file = pmFPAfileDefineFromConf(&status, config, filerule);
         if (!status) {
-            psError(PS_ERR_UNKNOWN, false, "failed to load file definition");
+            psError(PS_ERR_UNKNOWN, false, "failed to load file definition CONFIG");
             return false;
         }
@@ -39 +39 @@
         file = pmFPAfileDefineFromDetDB(&status, config, filerule, input, detrendType);
         if (!status) {
-            psError(PS_ERR_UNKNOWN, false, "failed to load file definition");
+            psError(PS_ERR_UNKNOWN, false, "failed to load file definition DETREND");
             return false;
         }

branches/eam_branches/ipp-20101103/ppImage/src/ppImageDetrendFree.c

@@ -13 +13 @@
     "PPIMAGE.FLAT",
     "PPIMAGE.SHUTTER",
+    "PPIMAGE.LINEARITY",
     NULL
 };
@@ -23 +24 @@
 
         pmFPAfile *file = psMetadataLookupPtr(&status, config->files, detrendTypes[i]); // File of interest
+        psTrace("pmFPAfileFree",1,"Working on %s\n",detrendTypes[i]);
         if (!file) continue; // not all detrends are used in any given run
 

branches/eam_branches/ipp-20101103/ppImage/src/ppImageDetrendNonLinear.c

@@ -44 +44 @@
 }
 
-bool ppImageDetrendNonLinear(pmReadout *input, ppImageOptions *options) {
+
+bool ppImageDetrendNonLinear(pmReadout *input, pmFPAview *detview, pmConfig  *config) {
+    bool status;
+
+    pmFPAfile *linearity_file = psMetadataLookupPtr(&status,config->files,"PPIMAGE.LINEARITY");
+    psFits *linearity_fits = linearity_file->fits;
+
+    char *extname = psMetadataLookupStr(&status,input->parent->concepts,"CELL.NAME");
+    if (!extname) {
+        psError(PS_ERR_IO, false, "missing CELL.NAME in concepts");
+        return(false);
+    }
+
+    if (!psFitsMoveExtName(linearity_fits,extname)) {
+        psError(PS_ERR_IO, false, "Unable to move to non-linearity table %s", extname);
+        return(false);
+    }
+  
+    psArray *table = psFitsReadTable(linearity_fits);
+    if (!table) {
+        psError(PS_ERR_IO, false, "Unable to read non-linearity table.\n");
+        return(false);
+    }
+
+    // It might be better to pack lookup table here...
+    // Why? I only use that lookup table once for the single cell it matches. 
+  
+    if (!pmNonLinearityApply(input,table)) {
+        psError(PS_ERR_UNKNOWN, false, "Unable to apply non-linearity corrections.\n");
+        psFree (table);
+        return(false);
+    }       
+    psFree (table);
+
+    return true;
+}
+
+bool ppImageDetrendNonLinear_Original(pmReadout *input, ppImageOptions *options) {
 
     psMetadataItem *concept;
@@ -59 +96 @@
 
       case PS_DATA_METADATA:
-        // XXX EAM: this is somewhat confusing : let's wrap in a function when i understand it
-
         // Go looking for the value in the hierarchy
         concept = psMetadataLookup(cell->concepts, options->nonLinearSource);

branches/eam_branches/ipp-20101103/ppImage/src/ppImageDetrendReadout.c

@@ -51 +51 @@
     }
 
-
-# if 0
+    // Subtract the overscan
+    if (options->doOverscan) {
+      if (!pmOverscanSubtract (input, options->overscan)) {
+        psError(PS_ERR_UNKNOWN, false, "Unable to subtract overscan.");
+        psFree(detview);
+        return false;
+      }
+    }
+
     // Non-linearity correction
     if (options->doNonLin) {
-        ppImageDetrendNonLinear(detrend->input, input, options);
-    }
-# endif
+      if (!ppImageDetrendNonLinear(input,detview,config)) {
+        psError(PS_ERR_UNKNOWN, false, "Unable to correct NonLinearity");
+        psFree(detview);
+        return(false);
+      }
+    }
 
     // set up the dark and bias
@@ -77 +87 @@
     }
 
-    // Bias, dark and overscan subtraction are all merged.
-    if (options->doBias || options->doOverscan) {
-        if (!pmBiasSubtract(input, options->overscan, bias, oldDark, view)) {
+    // Bias and temperature-independent-dark subtraction are merged.
+    if (options->doBias) {
+        if (!pmBiasSubtract(input, bias, oldDark, view)) {
             psError(PS_ERR_UNKNOWN, false, "Unable to subtract bias.");
             psFree(detview);
@@ -85 +95 @@
         }
     }
-
+    
     // Weight on the basis of pixel value needs to be done after the overscan has been subtracted
     if (options->doVarianceBuild) {

branches/eam_branches/ipp-20101103/ppImage/src/ppImageLoop.c

@@ -152 +152 @@
             ESCAPE("Unable to free detrend images");
         }
-
+    
         // Apply the fringe correction
         if (options->doFringe) {

branches/eam_branches/ipp-20101103/ppImage/src/ppImageOptions.c

@@ -8 +8 @@
 {
     psFree(options->overscan);
-    psFree(options->nonLinearData);
-    psFree(options->nonLinearSource);
+    // psFree(options->nonLinearData);
+    // psFree(options->nonLinearSource);
 }
 
@@ -130 +130 @@
         psMetadataItem *dataItem = psMetadataLookup(recipe, "NONLIN.DATA");
         if (! dataItem) {
-            psLogMsg(__func__, PS_LOG_ERROR, "Non-linearity correction desired, but unable to "
-                     "find NONLIN.DATA in recipe %s.", RECIPE_NAME);
+            psLogMsg("ppImage", PS_LOG_ERROR, "Non-linearity correction desired, but unable to find NONLIN.DATA in recipe %s.", RECIPE_NAME);
             exit(EXIT_FAILURE);
         }
@@ -147 +146 @@
             // This is a menu; we need the key
           case PS_DATA_METADATA:
-            {
-                bool status;
-                options->nonLinearSource = psMetadataLookupStr(&status, recipe, "NONLIN.SOURCE");
-                if (! status || ! options->nonLinearSource) {
-                    psLogMsg(__func__, PS_LOG_ERROR, "Non-linearity correction desired, but unable to "
-                            "find NONLIN.SOURCE in recipe %s.", RECIPE_NAME);
-                    exit(EXIT_FAILURE);
-                }
-            }
+            options->nonLinearSource = psMetadataLookupStr(&status, recipe, "NONLIN.SOURCE");
+            if (! status || ! options->nonLinearSource) {
+                psLogMsg("ppImage", PS_LOG_ERROR, "Non-linearity correction desired, but unable to find NONLIN.SOURCE in recipe %s.", RECIPE_NAME);
+                exit(EXIT_FAILURE);
+            }
             break;
           default:
-            psLogMsg(__func__, PS_LOG_ERROR, "Non-linearity correction desired, but "
-                    "NONLIN.DATA is of invalid type in recipe %s.", RECIPE_NAME);
+            psLogMsg("ppImage", PS_LOG_ERROR, "Non-linearity correction desired, but NONLIN.DATA is of invalid type in recipe %s.", RECIPE_NAME);
             exit(EXIT_FAILURE);
         }

branches/eam_branches/ipp-20101103/ppImage/src/ppImageParseCamera.c

@@ -73 +73 @@
             return NULL;
         }
+    }
+
+    if (options->doNonLin) {
+      if (!ppImageDefineFile(config, input->fpa, "PPIMAGE.LINEARITY", "LINEARITY",
+                             PM_FPA_FILE_LINEARITY, PM_DETREND_TYPE_LINEARITY)) {
+        psError(PS_ERR_IO, false, "Can't find a non-linearity correction source");
+        psFree(options);
+        return NULL;
+      }
     }