Changeset 28971

Timestamp:

Aug 19, 2010, 4:08:55 PM (16 years ago)

Author:

eugene

Message:

if we request S/N clipping, clip points with negative flux

File:

• branches/eam_branches/ipp-20100621/psModules/src/objects/pmSourceMoments.c (modified) (1 diff)

branches/eam_branches/ipp-20100621/psModules/src/objects/pmSourceMoments.c

@@ -145 +145 @@
             psF32 wDiff = *vWgt;
 
-            // skip pixels below specified significance level.  this is allowed, but should be
-            // avoided -- the over-weights the wings of bright stars compared to those of faint
-            // stars.
-            if (PS_SQR(pDiff) < minSN2*wDiff) continue;
-            // if (pDiff < 0) continue; // XXX : MWV says I should include < 0.0 valued points...
+            // skip pixels below specified significance level.  for a PSFs, this
+            // over-weights the wings of bright stars compared to those of faint stars.
+            // for the estimator used for extended source analysis (where the window
+            // function is allowed to be arbitrarily large), we need to clip to avoid
+            // negative second moments.
+            if (PS_SQR(pDiff) < minSN2*wDiff) continue; // 
+            if ((minSN > 0.0) && (pDiff < 0)) continue; // 
 
             // Apply a Gaussian window function.  Be careful with the window function.  S/N