Changeset 28401

Timestamp:

Jun 18, 2010, 10:47:02 AM (16 years ago)

Author:

Paul Price

Message:

Adding comment on race condition in psMemory: don't need to deal with it (here) because it is the user's responsibility not to completely free memory that's being used in a thread (without protection). No functional change.

File:

• trunk/psLib/src/sys/psMemory.c (modified) (1 diff)

trunk/psLib/src/sys/psMemory.c

@@ -452 +452 @@
     #endif
 
+    // XXX Looking at the reference counter is subject to a race condition because this function is generally
+    // not locked.  Normally this is not a problem because though we may increment and decrement references
+    // within a thread, we don't destroy the object completely (which is what we're checking for here).  It is
+    // the user's responsibility to protect against the complete destruction of memory either by not doing it
+    // or by locking on all reference changes for that memory.
     if (memBlock->refCounter < 1) {
         // using an unreferenced block of memory, are you?