Changeset 27064

Timestamp:

Feb 24, 2010, 2:51:03 PM (16 years ago)

Author:

Paul Price

Message:

Being more careful with errors.

File:

• trunk/ppImage/src/ppImageStatsOutput.c (modified) (2 diffs)

trunk/ppImage/src/ppImageStatsOutput.c

@@ -17 +17 @@
     // get the output stats filename
     const char *statsName = psMetadataLookupStr(&mdok, config->arguments, "STATS"); // Filename for statistics
-    if (!statsName && !strlen(statsName)) {
+    if (!statsName || !strlen(statsName)) {
         psError(PS_ERR_UNEXPECTED_NULL, false, "missing STATS entry in arguments list.");
         return false;
@@ -24 +24 @@
     // Write out
     psString resolved = pmConfigConvertFilename(statsName, config, true, true); // Resolved filename
+    if (!resolved) {
+        psError(psErrorCodeLast(), false, "Unable to resolve statistics file name");
+        return false;
+    }
     if (!psMetadataConfigWrite(stats, resolved)) {
-        psError(PS_ERR_IO, false, "Unable to serialize stats metadata.\n");
+        psError(psErrorCodeLast(), false, "Unable to serialize stats metadata.\n");
         psFree(resolved);
         return false;