Changeset 27059

Timestamp:

Feb 24, 2010, 2:08:58 PM (16 years ago)

Author:

Paul Price

Message:

More careful error checking on writing statistics file.

File:

• trunk/ppStack/src/ppStackFinish.c (modified) (2 diffs)

trunk/ppStack/src/ppStackFinish.c

@@ -79 +79 @@
         const char *statsMDC = psMetadataConfigFormat(options->stats);
         if (!statsMDC || strlen(statsMDC) == 0) {
-            psError(PS_ERR_IO, false, "Unable to get statistics MDC file.\n");
-        } else {
-            fprintf(options->statsFile, "%s", statsMDC);
+            psError(PS_ERR_IO, false, "Unable to get statistics MDC file.");
+            return false;
+        }
+        if (fprintf(options->statsFile, "%s", statsMDC) != strlen(statsMDC)) {
+            psError(PS_ERR_IO, false, "Unable to write statistics MDC file.");
+            return false;
         }
         psFree(statsMDC);
-        fclose(options->statsFile); options->statsFile = NULL;
+        if (fclose(options->statsFile) == EOF) {
+            psError(PS_ERR_IO, false, "Unable to close statistics MDC file.");
+            return false;
+        }
+        options->statsFile = NULL;
         pmConfigRunFilenameAddWrite(config, "STATS", psMetadataLookupStr(NULL, config->arguments, "STATS"));
     }
@@ -92 +99 @@
     if (dump) {
         if (!pmConfigDump(config, dump)) {
-            psError(PS_ERR_IO, false, "Unable to dump configuration.");
+            psError(psErrorCodeLast(), false, "Unable to dump configuration.");
             return false;
         }