Changeset 26594

Timestamp:

Jan 14, 2010, 10:19:12 AM (16 years ago)

Author:

eugene

Message:

pmSourceMoments now takes a mask value and correctly ANDs the image mask against that (needed to handle SUSPECT as opposed to BAD pixels); pmPeaks returns an empty, but non NON peak array if no peaks are found (this is a valid result)

Location:

branches/eam_branches/20091201/psModules/src

Files:

• imcombine/pmPSFEnvelope.c (modified) (2 diffs)
• imcombine/pmPSFEnvelope.h (modified) (1 diff)
• objects/pmPeaks.c (modified) (4 diffs)
• objects/pmSource.c (modified) (1 diff)
• objects/pmSource.h (modified) (1 diff)
• objects/pmSourceMoments.c (modified) (3 diffs)

branches/eam_branches/20091201/psModules/src/imcombine/pmPSFEnvelope.c

@@ -65 +65 @@
                      int radius,        // Radius of each PSF
                      const char *modelName,// Name of PSF model to use
-                     int xOrder, int yOrder // Order for PSF variation fit
+                     int xOrder, int yOrder, // Order for PSF variation fit
+                     psImageMaskType maskVal
                      )
 {
@@ -360 +361 @@
 
         // measure the source moments: tophat windowing, no pixel S/N cutoff
-        if (!pmSourceMoments(source, maxRadius, 0.0, 1.0)) {
+        // XXX probably should be passing the maskVal to this function so we can pass it along here...
+        if (!pmSourceMoments(source, maxRadius, 0.0, 1.0, maskVal)) {
             // Can't do anything about it; limp along as best we can
             psErrorClear();

branches/eam_branches/20091201/psModules/src/imcombine/pmPSFEnvelope.h

@@ -17 +17 @@
                      int radius,        // Radius of each PSF
                      const char *modelName, // Name of PSF model to use
-                     int xOrder, int yOrder // Order for PSF variation
+                     int xOrder, int yOrder, // Order for PSF variation
+                     psImageMaskType maskVal
     );
 

branches/eam_branches/20091201/psModules/src/objects/pmPeaks.c

@@ -375 +375 @@
     psU32 col = 0;
     psU32 row = 0;
-    psArray *list = NULL;
+    psArray *list = psArrayAllocEmpty(100);
 
     // Find peaks in row 0 only.
@@ -416 +416 @@
 
         } else {
-            psError(PS_ERR_UNKNOWN, true, "peak specified valid column range.");
+            psLogMsg ("psModules.objects", 5, "peak specified outside valid column range.");
         }
     }
@@ -501 +501 @@
                 }
             } else {
-                psError(PS_ERR_UNKNOWN, true, "peak specified outside valid column range.");
+                psLogMsg ("psModules.objects", 5, "peak specified outside valid column range.");
             }
 
@@ -545 +545 @@
             }
         } else {
-            psError(PS_ERR_UNKNOWN, true, "peak specified outside valid column range.");
+            psLogMsg ("psModules.objects", 5, "peak specified outside valid column range.");
         }
     }

branches/eam_branches/20091201/psModules/src/objects/pmSource.c

@@ -409 +409 @@
 
         // if we failed to find a valid peak, return the empty clump (failure signal)
-        if (peaks == NULL)
+        if (peaks == NULL) {
+            psError(PS_ERR_UNKNOWN, false, "failure in peak analysis for PSF clump.\n");
+            return emptyClump;
+        }
+
+        if (peaks->n == 0)
         {
             psLogMsg ("psphot", 3, "failed to find a peak in the PSF clump image\n");

branches/eam_branches/20091201/psModules/src/objects/pmSource.h

@@ -220 +220 @@
     float radius,     ///< Use a circle of pixels around the peak
     float sigma,      ///< size of Gaussian window function (<= 0.0 -> skip window)
-    float minSN       ///< minimum pixel significance
+    float minSN,              ///< minimum pixel significance
+    psImageMaskType maskVal
 );
 

branches/eam_branches/20091201/psModules/src/objects/pmSourceMoments.c

@@ -54 +54 @@
 # define VALID_RADIUS(X,Y,RAD2) (((RAD2) >= (PS_SQR(X) + PS_SQR(Y))) ? 1 : 0)
 
-bool pmSourceMoments(pmSource *source, psF32 radius, psF32 sigma, psF32 minSN)
+bool pmSourceMoments(pmSource *source, psF32 radius, psF32 sigma, psF32 minSN, psImageMaskType maskVal)
 {
     PS_ASSERT_PTR_NON_NULL(source, false);
@@ -114 +114 @@
         for (psS32 col = 0; col < source->pixels->numCols ; col++, vPix++, vWgt++) {
             if (vMsk) {
-                if (*vMsk) {
+                if (*vMsk & maskVal) {
                     vMsk++;
                     continue;
@@ -226 +226 @@
         for (psS32 col = 0; col < source->pixels->numCols ; col++, vPix++, vWgt++) {
             if (vMsk) {
-                if (*vMsk) {
+                if (*vMsk & maskVal) {
                     vMsk++;
                     continue;