Changeset 24347

Timestamp:

Jun 5, 2009, 4:08:32 PM (17 years ago)

Author:

jhoblitt

Message:

add basic valid key caching via memcached

Location:

trunk/Nebulous-Server

Files:

• Build.PL (modified) (1 diff)
• Changes (modified) (1 diff)
• lib/Nebulous/Server.pm (modified) (5 diffs)
• lib/Nebulous/Server/Config.pm (modified) (1 diff)

trunk/Nebulous-Server/Build.PL

@@ -10 +10 @@
     requires            => {
         'Apache2::Const'        => 0,
+        'Cache::Memcached::Managed' => '0.20',
         'Class::Accessor::Fast' => 0,
         'Config::YAML'          => '1.42',

trunk/Nebulous-Server/Changes

@@ -2 +2 @@
 
 0.17
+    - add basic valid key caching via memcached 
     - add params checking to Nebulous::Key::parse_neb_key()
     - restrict creation/modification/remove of xattrs to the user.* namespace

trunk/Nebulous-Server/lib/Nebulous/Server.pm

@@ -27 +27 @@
 use Params::Validate qw( validate validate_pos SCALAR SCALARREF UNDEF BOOLEAN );
 use URI::file;
-
-__PACKAGE__->mk_accessors(qw( log sql config ));
+use Cache::Memcached::Managed;
+
+__PACKAGE__->mk_accessors(qw( log sql config cache ));
 
 use constant SUBPATH_DEPTH  => 2;
@@ -62 +63 @@
     $self->sql($sql);
     $self->config($config);
-
+    $self->cache(Cache::Memcached::Managed->new($config->memcached));
     $log->debug( "leaving" );
 
@@ -1577 +1578 @@
             # remove it too
             if ( $instances == 1 ) {
+                # remove key from cache
+                $self->cache->delete($key->path);
+
                 # we just removed the last instance
                 my $query = $db->prepare_cached( $sql->delete_object );
@@ -1895 +1899 @@
     $log->logdie("$@") if $@;
 
+    # check cache first
+    my $cached = $self->cache->get($key->path);
+    if (defined $cached) {
+        $log->debug( "key $key found in cache" );
+        $log->debug( "leaving" );
+        return 1;
+    } else {
+        $log->debug( "key $key not found in cache" );
+    }
+
     my $db  = $self->db($key);
 
@@ -1911 +1925 @@
 
     if (defined $ext_id) {
-        $log->debug( "key is valid" );
+        $log->debug( "key found in db" );
         $log->debug( "leaving" );
         return 1;
     } 
 
-    $log->debug( "key not found" );
+    $log->debug( "key not found in db" );
     $log->debug( "leaving" );
 

trunk/Nebulous-Server/lib/Nebulous/Server/Config.pm

@@ -49 +49 @@
     dbuser      => { type => SCALAR, optional => 1 },
     dbpasswd    => { type => SCALAR, optional => 1 },
+    memcached   => { type => SCALAR, default => '127.0.0.1:11311' },
 };