Changeset 23793

Timestamp:

Apr 9, 2009, 10:16:54 PM (17 years ago)

Author:

Paul Price

Message:

Making version information not dependent upon running configure, but on make.

Location:

trunk/psLib

Files:

• autogen.sh (modified) (1 diff)
• configure.ac (modified) (1 diff)
• m4/ipp_stdopts.m4 (modified) (1 diff)
• src/sys (modified) (1 prop)
• src/sys/Makefile.am (modified) (2 diffs)
• src/sys/psConfigure.c (modified) (3 diffs)
• src/sys/psVersionDefinitions.h.in (added)

trunk/psLib/autogen.sh

@@ -19 +19 @@
 fi
 
-ACLOCAL="aclocal $ACLOCAL_FLAGS"
+ACLOCAL="aclocal -I `pwd`/m4 $ACLOCAL_FLAGS"
 AUTOHEADER=autoheader
 AUTOMAKE=automake

trunk/psLib/configure.ac

@@ -341 +341 @@
 CPPFLAGS=${TMP_CPPFLAGS}
 
-IPP_VERSION(PSLIB)
-AC_SUBST(PSLIB_VERSION,[$PSLIB_VERSION])
-AC_SUBST(PSLIB_BRANCH,[$PSLIB_BRANCH])
-AC_SUBST(PSLIB_SOURCE,[$PSLIB_SOURCE])
+IPP_VERSION
 
 dnl ------- enable -Werror after all of the probes have run ---------

trunk/psLib/m4/ipp_stdopts.m4

@@ -50 +50 @@
         )
         
-        [$1]_VERSION="UNKNOWN"
-        [$1]_BRANCH="UNKNOWN"
-        [$1]_SOURCE="UNKNOWN"
         AS_IF([test "x$enable_version" = xtrue],
                 [AC_PATH_PROG([SVNVERSION], [svnversion])
-                AC_PATH_PROG([SVN], [svn])
-                AC_PROG_SED
-                AS_IF([test "x$SVNVERSION" != x], [$1]_VERSION=`$SVNVERSION`)
-                AS_IF([test "x$SVN" != x],
-                        [[$1]_BRANCH=`$SVN info | $SED -n -e '/URL:/ h' -e '/Repository Root:/ { x; H; x; s|Repository Root: \(.*\)\nURL: \1\(.*\)|\2| ; s|^/|| ; s|/[a-zA-Z]*/src.*|| ; p }'`
-                        [$1]_SOURCE=`$SVN info | $SED -n -e 's/Repository UUID: // p'`])
-                ]
+                AC_PATH_PROG([SVN], [svn])]
         )
-        
-dnl     AC_SUBST([$1]_VERSION,[[$1]_VERSION])
-dnl     AC_SUBST([$1]_BRANCH,[[$1]_BRANCH])
-dnl     AC_SUBST([$1]_SOURCE,[[$1]_SOURCE])
+        AC_PROG_SED
+        AM_CONDITIONAL([HAVE_SVNVERSION], [test "x$SVNVERSION" != x])
+        AM_CONDITIONAL([HAVE_SVN], [test "x$SVN" != x])
 ])

trunk/psLib/src/sys

@@ -11 +11 @@
 *.bbg
 *.da
+psVersionDefinitions.h

@@ -11 +11 @@
 *.bbg
 *.da
+psVersionDefinitions.h

trunk/psLib/src/sys/Makefile.am

@@ -3 +3 @@
 noinst_LTLIBRARIES = libpslibsys.la
 
+if HAVE_SVNVERSION
+PSLIB_VERSION=`$(SVNVERSION) ../..`
+else
+PSLIB_VERSION="UNKNOWN"
+endif
+
+if HAVE_SVN
+PSLIB_BRANCH=`$(SVN) info ../.. | $(SED) -n -e '/URL:/ h' -e '/Repository Root:/ { x; H; x; s|Repository Root: \(.*\)\nURL: \1\(.*\)|\2| ; s|^/|| ; s|/[a-zA-Z]*/src.*|| ; p }'`
+PSLIB_SOURCE=`$(SVN) info | $(SED) -n -e 's/Repository UUID: // p'`
+else
+PSLIB_BRANCH="UNKNOWN"
+PSLIB_SOURCE="UNKNOWN"
+endif
+
 # Force recompilation of psConfigure.c, since it gets the version information
-psConfigure.c: FORCE
-        touch psConfigure.c
+psConfigure.c: psVersionDefinitions.h
+psVersionDefinitions.h: psVersionDefinitions.h.in FORCE
+        -$(RM) psVersionDefinitions.h
+        $(SED) -e "s|@PSLIB_VERSION@|\"$(PSLIB_VERSION)\"|" -e "s|@PSLIB_BRANCH@|\"$(PSLIB_BRANCH)\"|" -e "s|@PSLIB_SOURCE@|\"$(PSLIB_SOURCE)\"|" psVersionDefinitions.h.in > psVersionDefinitions.h
 FORCE: ;
 
-libpslibsys_la_CPPFLAGS = $(SRCINC) $(PSLIB_CFLAGS) $(CFITSIO_CFLAGS) -DPSLIB_VERSION=$(PSLIB_VERSION) -DPSLIB_BRANCH=$(PSLIB_BRANCH) -DPSLIB_SOURCE=$(PSLIB_SOURCE)
+libpslibsys_la_CPPFLAGS = $(SRCINC) $(PSLIB_CFLAGS) $(CFITSIO_CFLAGS)
 libpslibsys_la_SOURCES = \
         psAbort.c \
@@ -24 +40 @@
         strcasestr.c
 
-EXTRA_DIST = sys.i psErrorCodes.c.in psErrorCodes.h.in
+EXTRA_DIST = sys.i psErrorCodes.c.in psErrorCodes.h.in psVersion.h
 
-BUILT_SOURCES = psErrorCodes.c
+BUILT_SOURCES = psErrorCodes.c psVersion.h
 
 psErrorCodes.c: ../psErrorCodes_$(PS_LANG).dat psErrorCodes.c.in psErrorCodes.h

trunk/psLib/src/sys/psConfigure.c

@@ -44 +44 @@
 #include "psMemory.h"
 
+#include "psVersionDefinitions.h"
+
 static char *memCheckName = NULL;       // Filename to which to write results of mem check
 static FILE *memCheckFile = NULL;       // File to which to write results of mem check
@@ -57 +59 @@
 #endif
 
-#define xstr(s) str(s)
-#define str(s) #s
-
 psString psLibVersion(void)
 {
     char *value = NULL;
-    psStringAppend(&value, "%s@%s", xstr(PSLIB_BRANCH), xstr(PSLIB_VERSION));
+    psStringAppend(&value, "%s@%s", PSLIB_BRANCH, PSLIB_VERSION);
     return value;
 }
@@ -69 +68 @@
 psString psLibSource(void)
 {
-    return psStringCopy(xstr(PSLIB_SOURCE));
+    return psStringCopy(PSLIB_SOURCE);
 }
 

@@ -11 +11 @@
 *.bbg
 *.da
+psVersionDefinitions.h