Changeset 21237

Timestamp:

Jan 29, 2009, 5:37:59 PM (17 years ago)

Author:

Paul Price

Message:

difftool -definebyquery was generating diffs using stacks that had failed. This should fix that.

Location:

trunk/ippTools

Files:

• share/difftool_definebyquery_part2.sql (modified) (2 diffs)
• src/difftool.c (modified) (1 diff)

trunk/ippTools/share/difftool_definebyquery_part2.sql

@@ -1 @@
--- insert skycells to diff 
+-- insert skycells to diff
 INSERT INTO skycellsToDiff
     SELECT
@@ -19 +19 @@
             FROM stackRun
             JOIN stackSumSkyfile USING(stack_id)
+            WHERE stackSumSkyfile.fault = 0
+                AND stackRun.state = 'full'
             -- stacks where hook %s
-            GROUP BY 
+            GROUP BY
                 skycell_id,
                 filter

trunk/ippTools/src/difftool.c

@@ -1004 +1004 @@
     if (psListLength(stackWhere->list)) {
         psString whereClause = psDBGenerateWhereConditionSQL(stackWhere, NULL);
-        psStringAppend(&stackQuery, "\nWHERE %s", whereClause);
+        psStringAppend(&stackQuery, "\nAND %s", whereClause);
         psFree(whereClause);
     } else {