Changeset 20417

Timestamp:

Oct 27, 2008, 2:13:19 PM (18 years ago)

Author:

Paul Price

Message:

Shouldn't generate an error when the key doesn't exist --- test for it first.

File:

• trunk/psLib/src/types/psMetadata.c (modified) (2 diffs)

trunk/psLib/src/types/psMetadata.c

@@ -12 +12 @@
  *  @author Ross Harman, MHPCC
  *
- *  @version $Revision: 1.173 $ $Name: not supported by cvs2svn $
- *  @date $Date: 2008-10-14 01:48:30 $
+ *  @version $Revision: 1.174 $ $Name: not supported by cvs2svn $
+ *  @date $Date: 2008-10-28 00:13:19 $
  *
  *  Copyright 2004-2005 Maui High Performance Computing Center, University of Hawaii
@@ -670 +670 @@
         }
 
-        if (flags & PS_META_REPLACE) {
+        if ((flags & PS_META_REPLACE) && psMetadataLookup(md, key)) {
             // drop the existing entry or entries
-            psMetadataRemoveKey(md, key);
+            if (!psMetadataRemoveKey(md, key)) {
+                psError(PS_ERR_UNKNOWN, false, "Unable to remove existing item to replace");
+                return false;
+            }
         } else {
             // elevate the existing hash entry to be PS_DATA_METADATA_MULTI