Changeset 19966

Timestamp:

Oct 7, 2008, 2:52:13 PM (18 years ago)

Author:

Paul Price

Message:

value = sqrt(value) is not good when value is undefined.
I think RMS should be robust stdev, not robust median.

File:

• trunk/ppStats/src/ppStatsFromMetadataStats.c (modified) (3 diffs)

trunk/ppStats/src/ppStatsFromMetadataStats.c

@@ -2 +2 @@
 
 // calculate the stats for the non-constant entries (already calculated)
-bool ppStatsFromMetadataStats(psArray *entries) {
-
+bool ppStatsFromMetadataStats(psArray *entries)
+{
     for (int i = 0; i < entries->n; i++) {
         ppStatsEntry *entry = entries->data[i];
@@ -18 +18 @@
         psStatsOptions option;
         if (!strcasecmp (entry->statistic, "RMS")) {
-            option = psStatsOptionFromString ("ROBUST_MEDIAN");
+            option = psStatsOptionFromString ("ROBUST_STDEV");
         } else if (!strcasecmp (entry->statistic, "SUM")) {
             option = psStatsOptionFromString ("SAMPLE_MEAN");
@@ -35 +35 @@
         double value;
         if (!strcasecmp (entry->statistic, "RMS")) {
-            value = sqrt(value);
+            value = stats->robustStdev;
         } else if (!strcasecmp (entry->statistic, "SUM")) {
             value = stats->sampleMean * entry->vector->n;