Changeset 19715

Timestamp:

Sep 23, 2008, 2:37:27 PM (18 years ago)

Author:

jhoblitt

Message:

allow ->replicate() volume param to be undef

Location:

trunk/Nebulous

Files:

• Changes (modified) (1 diff)
• lib/Nebulous/Client.pm (modified) (2 diffs)
• t/52_client_replicate.t (modified) (3 diffs)

trunk/Nebulous/Changes

@@ -2 +2 @@
 
 0.10
+    - allow ->replicate() volume param to be undef
     - fix ->delete() still work if the neb implies a volume on which there is
       no instance

trunk/Nebulous/lib/Nebulous/Client.pm

@@ -1 +1 @@
 # Copyright (c) 2004-2008  Joshua Hoblitt
 #
-# $Id: Client.pm,v 1.59 2008-09-11 23:02:23 jhoblitt Exp $
+# $Id: Client.pm,v 1.60 2008-09-24 00:36:56 jhoblitt Exp $
 
 package Nebulous::Client;
@@ -191 +191 @@
         {
             # volume
-            type        => SCALAR,
+            type        => SCALAR|UNDEF,
             optional    => 1,
         },

trunk/Nebulous/t/52_client_replicate.t

@@ -3 +3 @@
 # Copryight (C) 2004-2005  Joshua Hoblitt
 #
-# $Id: 52_client_replicate.t,v 1.1 2005-12-03 02:52:31 jhoblitt Exp $
+# $Id: 52_client_replicate.t,v 1.2 2008-09-24 00:36:56 jhoblitt Exp $
 
 use strict;
@@ -10 +10 @@
 use Apache::Test qw( -withtestmore );
 
-plan tests => 11;
+plan tests => 13;
 
 use lib qw( ./t ./lib );
@@ -45 +45 @@
 
     my $uri = $neb->replicate( "foo", "node01" );
+
+    ok( $uri, "good replication" );
+    ok( -e _get_file_path( $uri ), "file exists" );
+}
+
+Test::Nebulous->setup;
+
+{
+    # key, $volume = undef (same as saying no volume)
+    my $neb = Nebulous::Client->new(
+        proxy => "http://$hostport/nebulous",
+    );
+    $neb->create( "neb://node01/foo" );
+
+    my $uri = $neb->replicate( "neb://node01/foo", undef );
 
     ok( $uri, "good replication" );