Changeset 19249

Timestamp:

Aug 27, 2008, 3:37:35 PM (18 years ago)

Author:

Paul Price

Message:

stacktool wasn't applying the restrictions specified on the command-line when inserting warps into stackInputSkyfile. Needed to split share/stacktool_definebyquery_insert_random.sql into two parts to make it work with the restrictions.

Location:

trunk/ippTools

Files:

• share/Makefile.am (modified) (1 diff)
• share/stacktool_definebyquery_insert_random.sql (deleted)
• share/stacktool_definebyquery_insert_random_part1.sql (added)
• share/stacktool_definebyquery_insert_random_part2.sql (added)
• src/stacktool.c (modified) (10 diffs)

trunk/ippTools/share/Makefile.am

@@ -132 +132 @@
      regtool_revertprocessedimfile.sql \
      stacktool_definebyquery_insert.sql \
-     stacktool_definebyquery_insert_random.sql \
+     stacktool_definebyquery_insert_random_part1.sql \
+     stacktool_definebyquery_insert_random_part2.sql \
      stacktool_definebyquery_part1.sql \
      stacktool_definebyquery_part2.sql \

trunk/ippTools/src/stacktool.c

@@ -141 +141 @@
     PXOPT_LOOKUP_TIME(registered, config->args, "-registered", false, false);
 
-    if (!psListLength(where->list) && 
-        !psMetadataLookupBool(NULL, config->args, "-all")) {
+    if (!psListLength(where->list) &&
+        !psMetadataLookupBool(NULL, config->args, "-all")) {
         psFree(where);
         psError(PXTOOLS_ERR_DATA, false, "search parameters are required");
@@ -159 +159 @@
         psFree(whereClause);
     }
-    psFree(where);
 
     psString groupby = pxDataGet("stacktool_definebyquery_part2.sql");
     if (!groupby) {
         psError(PXTOOLS_ERR_DATA, false, "failed to retreive SQL statement");
+        psFree(where);
         return false;
     }
@@ -202 +202 @@
         psError(PS_ERR_UNKNOWN, false, "database error");
         psFree(select);
+        psFree(where);
         return false;
     }
@@ -217 +218 @@
                 psError(PXTOOLS_ERR_PROG, false, "unknown error");
         }
-
+        psFree(where);
         return false;
     }
@@ -223 +224 @@
         psTrace("stacktool", PS_LOG_INFO, "no rows found");
         psFree(output);
+        psFree(where);
         return true;
     }
@@ -228 +230 @@
     psString insert = NULL;             // Insertion query
     if (randomLimit > 0) {
-        insert = pxDataGet("stacktool_definebyquery_insert_random.sql");
+        insert = pxDataGet("stacktool_definebyquery_insert_random_part1.sql");
     } else {
         insert = pxDataGet("stacktool_definebyquery_insert.sql");
@@ -234 +236 @@
     if (!insert) {
         psError(PXTOOLS_ERR_DATA, false, "failed to retreive SQL statement");
-        return false;
+        psFree(where);
+        return false;
+    }
+
+    if (psListLength(where->list)) {
+        psString whereClause = psDBGenerateWhereConditionSQL(where, NULL);
+        psStringAppend(&select, " AND %s", whereClause);
+        psFree(whereClause);
+    }
+    psFree(where);
+
+    if (randomLimit > 0) {
+        psString part2 = pxDataGet("stacktool_definebyquery_insert_random_part2.sql");
+        if (!part2) {
+            psError(PXTOOLS_ERR_DATA, false, "failed to retreive SQL statement");
+            psFree(insert);
+            return false;
+        }
+        psStringAppend(&insert, "%s", part2);
+        psFree(part2);
     }
 
     if (!psDBTransaction(config->dbh)) {
         psError(PS_ERR_UNKNOWN, false, "database error");
+        psFree(where);
         return false;
     }
@@ -288 +310 @@
             0,                          // ID
             "new",                      // state
-            workdir, 
+            workdir,
             NULL,                       // workdir_state
-            registered, 
-            skycell_id, 
-            tess_id, 
+            registered,
+            skycell_id,
+            tess_id,
             filter);
 
@@ -324 +346 @@
         psFree(idString);
 
-        // XXX this insert uses a select to generate the list of warp_ids for the stack,
-        // we have applied a set of criteria above (WHERE) to select the relevant warps
-        // this insert needs to use exactly the same restrictions (race condition is probably not critical)
-        // the insert below seems to only restrict matches to the skycell, tess, and filter
+        // XXX this insert uses a select to generate the list of warp_ids for the stack,
+        // we have applied a set of criteria above (WHERE) to select the relevant warps
+        // this insert needs to use exactly the same restrictions (race condition is probably not critical)
+        // the insert below seems to only restrict matches to the skycell, tess, and filter
         if ((randomLimit > 0 && !p_psDBRunQuery(config->dbh, thisInsert, skycell_id, tess_id, filter,
                                                 randomLimit)) ||
@@ -384 +406 @@
 
     stackRunRow *run = stackRunRowAlloc(
-        0,                              // ID
-        "new",                          // state
-        workdir, 
-        NULL,                           // workdir_state
-        registered, 
-        skycell_id, 
-        tess_id, 
-        filter);
+        0,                              // ID
+        "new",                          // state
+        workdir,
+        NULL,                           // workdir_state
+        registered,
+        skycell_id,
+        tess_id,
+        filter);
 
     if (!run) {