Changeset 17716

Timestamp:

May 16, 2008, 10:22:29 AM (18 years ago)

Author:

jhoblitt

Message:

call sync on newly created files from Nebulous::Server::_create_empty_file()
improved error strings in Nebulous::Server::find_instances()

Location:

trunk/Nebulous-Server

Files:

• Changes (modified) (1 diff)
• lib/Nebulous/Server.pm (modified) (5 diffs)

trunk/Nebulous-Server/Changes

@@ -1 +1 @@
 Revision history for Nebulous
+
+0.11
+    - call sync on newly created files from
+      Nebulous::Server::_create_empty_file()
+    - improved error strings in Nebulous::Server::find_instances()
 
 0.10 Wed May 14 17:26:48 HST 2008

trunk/Nebulous-Server/lib/Nebulous/Server.pm

@@ -1 +1 @@
 # Copyright (c) 2004-2008  Joshua Hoblitt
 #
-# $Id: Server.pm,v 1.71 2008-05-15 03:27:28 jhoblitt Exp $
+# $Id: Server.pm,v 1.72 2008-05-16 20:22:29 jhoblitt Exp $
 
 package Nebulous::Server;
@@ -9 +9 @@
 no warnings qw( uninitialized );
 
-our $VERSION = '0.10';
+our $VERSION = '0.11';
 
 use base qw( Class::Accessor::Fast );
@@ -937 +937 @@
             unless ($rows > 0) {
                 $query->finish;
-                $log->logdie("no instances on storage volume: $vol_name or volume is not available");
+                $log->logdie("no instances on storage volume or volume is not avaiable for key: $key volume: $vol_name");
             }
         } else {
@@ -945 +945 @@
             unless ($rows > 0) {
                 $query->finish;
-                $log->logdie("no instances available");
+                $log->logdie("no instances available for key: $key");
             }
         }
@@ -1295 +1295 @@
         unless (open($fh, '>', $path));
 
+    # chmod before fsync() to make sure the changed perms hit the disk too
+    die "can not chmod $path: $!"
+        unless (chmod 0664, $path);
+
+    die "can not flush $path: $!"
+        unless ($fh->flush);
+
+    die "can not sync $path: $!"
+        unless ($fh->sync);
+
     die "can not close $path: $!"
         unless (close($fh));
-
-    die "can not chmod $path: $!"
-        unless (chmod 0664, $path);
 
     return $path;