Changeset 17620

Timestamp:

May 9, 2008, 3:15:13 PM (18 years ago)

Author:

jhoblitt

Message:

change listxattr_object() to return an arrayref

Location:

trunk/Nebulous-Server

Files:

• Changes (modified) (1 diff)
• lib/Nebulous/Server.pm (modified) (2 diffs)
• t/14_server_xattr.t (modified) (7 diffs)

trunk/Nebulous-Server/Changes

@@ -2 +2 @@
 
 0.10
+    - change listxattr_object() to return an arrayref
     - change default log level to 'WARN'
     - fix _is_valid_object_key() to handle nebulous keys

trunk/Nebulous-Server/lib/Nebulous/Server.pm

@@ -1 +1 @@
 # Copyright (c) 2004-2008  Joshua Hoblitt
 #
-# $Id: Server.pm,v 1.65 2008-05-06 23:07:27 jhoblitt Exp $
+# $Id: Server.pm,v 1.66 2008-05-10 01:15:13 jhoblitt Exp $
 
 package Nebulous::Server;
@@ -794 +794 @@
     $log->debug("leaving");
 
-    return @xattrs;
+    return \@xattrs;
 }
 

trunk/Nebulous-Server/t/14_server_xattr.t

@@ -3 +3 @@
 # Copryight (C) 2007  Joshua Hoblitt
 #
-# $Id: 14_server_xattr.t,v 1.4 2008-03-20 21:10:14 jhoblitt Exp $
+# $Id: 14_server_xattr.t,v 1.5 2008-05-10 01:11:58 jhoblitt Exp $
 
 use strict;
@@ -30 +30 @@
     ok($neb->setxattr_object('foo', 'bar', 'baz', 'create'), 'set object xattr');
     {
-        my @xattrs = $neb->listxattr_object('foo');
+        my $xattrs = $neb->listxattr_object('foo');
         is(scalar @xattrs, 1, 'number of xattrs');
-        is($xattrs[0], 'bar', 'xattr name');
+        is(@$xattrs[0], 'bar', 'xattr name');
     }
 
@@ -40 +40 @@
     ok($neb->removexattr_object('foo', 'bar'), "remove object xattr");
     {
-        my @xattrs = $neb->listxattr_object('foo');
-        is(scalar @xattrs, 0, 'number of xattrs');
+        my $xattrs = $neb->listxattr_object('foo');
+        is(scalar @$xattrs, 0, 'number of xattrs');
     }
 }
@@ -56 +56 @@
     
     {
-        my @xattrs = $neb->listxattr_object('foo');
-        is(scalar @xattrs, 2, 'number of xattrs');
-        is($xattrs[0], 'bar', 'xattr name');
-        is($xattrs[1], 'bonk', 'xattr name');
+        my $xattrs = $neb->listxattr_object('foo');
+        is(scalar @$xattrs, 2, 'number of xattrs');
+        is(@$xattrs[0], 'bar', 'xattr name');
+        is(@$xattrs[1], 'bonk', 'xattr name');
     }
 
@@ -70 +70 @@
     ok($neb->removexattr_object('foo', 'bonk'), "remove object xattr");
     {
-        my @xattrs = $neb->listxattr_object('foo');
-        is(scalar @xattrs, 0, 'number of xattrs');
+        my $xattrs = $neb->listxattr_object('foo');
+        is(scalar @$xattrs, 0, 'number of xattrs');
     }
 }
@@ -86 +86 @@
     
     {
-        my @xattrs = $neb->listxattr_object('foo');
-        is(scalar @xattrs, 1, 'number of xattrs');
-        is($xattrs[0], 'bar', 'xattr name');
+        my $xattrs = $neb->listxattr_object('foo');
+        is(scalar @$xattrs, 1, 'number of xattrs');
+        is(@$xattrs[0], 'bar', 'xattr name');
     }
 
@@ -96 +96 @@
     ok($neb->removexattr_object('foo', 'bar'), "remove object xattr");
     {
-        my @xattrs = $neb->listxattr_object('foo');
-        is(scalar @xattrs, 0, 'number of xattrs');
+        my $xattrs = $neb->listxattr_object('foo');
+        is(scalar @$xattrs, 0, 'number of xattrs');
     }
 }