Changeset 16888

Timestamp:

Mar 8, 2008, 11:26:00 AM (18 years ago)

Author:

eugene

Message:

add comments re thread safety

Location:

trunk/Ohana/src/opihi/lib.shell

Files:

• CommandOps.c (modified) (1 diff)
• ConfigInit.c (modified) (3 diffs)
• MacroOps.c (modified) (1 diff)

trunk/Ohana/src/opihi/lib.shell/CommandOps.c

@@ -1 +1 @@
 # include "opihi.h"
+
+// the command table is only modified by macro_create: if thread protection is needed, it
+// should be added there.  it may not be needed if programs only call macro_create in a
+// single thread.  pantasks_server only calls macro_create in the 'input' thread, so it is
+// safe.
 
 // if the user has installed the libedit version of readline, we need to modify a couple symbols:

trunk/Ohana/src/opihi/lib.shell/ConfigInit.c

@@ -3 +3 @@
 static char *GlobalConfig;
 
+// this function is only called at start, so it is not thread protect
 int ConfigInit (int *argc, char **argv) {
 
@@ -19 +20 @@
   free (file);
   return (TRUE);
+}
+
+// this function is only called at shutdown, so it is not thread protect
+void ConfigFree () {
+  if (GlobalConfig) free (GlobalConfig);
+  return;
 }
 
@@ -65 +72 @@
 }
 
-void ConfigFree () {
-  if (GlobalConfig) free (GlobalConfig);
-  return;
-}

trunk/Ohana/src/opihi/lib.shell/MacroOps.c

@@ -1 +1 @@
 # include "opihi.h"
+
+// the macro table is only modified by macro_create: if thread protection is needed, it
+// should be added there.  it may not be needed if programs only call macro_create in a
+// single thread.  pantasks_server only calls macro_create in the 'input' thread, so it is
+// safe.
 
 static char dot[] = ".";