Changeset 16831

Timestamp:

Mar 5, 2008, 11:20:38 AM (18 years ago)

Author:

Paul Price

Message:

Only create output PSF for ppStack when photometry isn't being
performed. When it is, the file already exists.
PSFs aren't optional.

File:

• trunk/ppStack/src/ppStackCamera.c (modified) (4 diffs)

trunk/ppStack/src/ppStackCamera.c

@@ -72 +72 @@
 {
     bool haveWeights = false;           // Do we have weight maps?
-    bool havePSFs = false;              // Do we have PSFs?
 
     psMetadata *inputs = psMetadataLookupMetadata(NULL, config->arguments, "INPUTS"); // The inputs info
@@ -168 +167 @@
         }
 
-        // Optionally add the psf file
-        if (psf && strlen(psf) > 0) {
-            havePSFs = true;
+        // Add the psf file
+        if (!psf || strlen(psf) == 0) {
+            psError(PS_ERR_UNEXPECTED_NULL, true, "Unable to find PSF %d", i);
+            return false;
+        } else {
             psArray *psfFiles = psArrayAlloc(1); // Array of filenames for this FPA
             psfFiles->data[0] = psMemIncrRefCounter(psf);
@@ -315 +316 @@
 
 
-    // Output PSF
-    if (havePSFs) {
-        pmFPAfile *outPSF = pmFPAfileDefineOutput(config, output->fpa, "PSPHOT.PSF.SAVE");
-        if (!outPSF) {
-            psError(PS_ERR_IO, false, _("Unable to generate output file from PSPHOT.PSF.SAVE"));
-            return false;
-        }
-        if (outPSF->type != PM_FPA_FILE_PSF) {
-            psError(PS_ERR_IO, true, "PSPHOT.PSF.SAVE is not of type PSF");
-            return false;
-        }
-        outPSF->save = true;
-    }
-
-    // Sources for use as stamps
-    bool status = false;                // Found the file?
-    pmFPAfile *sources = pmFPAfileDefineFromArgs(&status, config, "PPSTACK.SOURCES", "PPSTACK.SOURCES");
-    if (!status) {
-        psError(PS_ERR_IO, false, "Failed to load file definition PPSTACK.SOURCES");
-        return false;
-    }
-    if (sources && sources->type != PM_FPA_FILE_CMF) {
-        psError(PS_ERR_IO, true, "PPSTACK.SOURCES is not of type CMF");
-        return false;
-    }
-
     // For photometry, we operate on the chip-mosaicked image
     // we create a copy of the mosaicked image for psphot so we can write out a clean image
@@ -360 +335 @@
             return false;
         }
+    } else {
+        // Output PSF --- only required if photometry is not being performed
+        pmFPAfile *outPSF = pmFPAfileDefineOutput(config, output->fpa, "PSPHOT.PSF.SAVE");
+        if (!outPSF) {
+            psError(PS_ERR_IO, false, _("Unable to generate output file from PSPHOT.PSF.SAVE"));
+            return false;
+        }
+        if (outPSF->type != PM_FPA_FILE_PSF) {
+            psError(PS_ERR_IO, true, "PSPHOT.PSF.SAVE is not of type PSF");
+            return false;
+        }
+        outPSF->save = true;
+    }
+
+    // Sources for use as stamps
+    bool status = false;                // Found the file?
+    pmFPAfile *sources = pmFPAfileDefineFromArgs(&status, config, "PPSTACK.SOURCES", "PPSTACK.SOURCES");
+    if (!status) {
+        psError(PS_ERR_IO, false, "Failed to load file definition PPSTACK.SOURCES");
+        return false;
+    }
+    if (sources && sources->type != PM_FPA_FILE_CMF) {
+        psError(PS_ERR_IO, true, "PPSTACK.SOURCES is not of type CMF");
+        return false;
     }