Changeset 16459

Timestamp:

Feb 13, 2008, 3:32:33 PM (18 years ago)

Author:

eugene

Message:

plug leak

Location:

trunk/Ohana/src/opihi

Files:

• lib.data/page.c (modified) (1 diff)
• lib.shell/convert_to_RPN.c (modified) (1 diff)
• pcontrol/ResetJob.c (modified) (1 diff)
• pcontrol/StopHosts.c (modified) (1 diff)

trunk/Ohana/src/opihi/lib.data/page.c

@@ -22 +22 @@
     free (page[0].words);
     free (page[0].value);
+    free (page);
 }
 

trunk/Ohana/src/opihi/lib.shell/convert_to_RPN.c

@@ -163 +163 @@
   /*** free up unused stack space ***/
 
-  // XXX there should not be any un-freed op_stacks at this point
-  // clean_stack (op_stack, NSTACK);
+  // If we parsed everything above, there should not be any un-freed op_stacks at this
+  // point.  However, if we had a syntax error, we will have op_stack entries left behind.
+  delete_stack (op_stack, NSTACK);
   free (op_stack);
 

trunk/Ohana/src/opihi/pcontrol/ResetJob.c

@@ -46 +46 @@
   }
 
-  gprint (GP_ERR, "programming error in GetJobOutput (should not reach here)\n");
+  gprint (GP_ERR, "programming error in ResetJob (should not reach here)\n");
+  FreeIOBuffer (&buffer);
   pcontrol_exit (1);
   return (FALSE);

trunk/Ohana/src/opihi/pcontrol/StopHosts.c

@@ -76 +76 @@
   InitIOBuffer (&buffer, 0x100);
   status = PclientCommand (host, "exit", "Goodbye", &buffer);
+  FreeIOBuffer (&buffer);
 
   /* check on success of pclient command */