Changeset 16184

Timestamp:

Jan 22, 2008, 2:46:06 PM (18 years ago)

Author:

jhoblitt

Message:

fix dangling statement handle in delete_instance()

Location:

trunk

Files:

• Nebulous-Server/lib/Nebulous/Server.pm (modified) (5 diffs)
• Nebulous/lib/Nebulous/Server.pm (modified) (5 diffs)

trunk/Nebulous-Server/lib/Nebulous/Server.pm

@@ -1 +1 @@
 # Copyright (c) 2004  Joshua Hoblitt
 #
-# $Id: Server.pm,v 1.45 2007-05-09 00:45:21 jhoblitt Exp $
+# $Id: Server.pm,v 1.46 2008-01-23 00:46:06 jhoblitt Exp $
 
 package Nebulous::Server;
@@ -928 +928 @@
 
             unless ( $rows > 0 ) {
+                $query->finish;
                 $log->logdie( "no instance is associated with uri" );
             }
@@ -933 +934 @@
             $so_id = $query->fetchrow_hashref->{ 'so_id' };
             $query->finish;
+
         }
 
@@ -947 +949 @@
             my $query = $db->prepare_cached( $sql->delete_instance );
             my $rows = $query->execute( $uri );
+            $query->finish;
             
             # if we affected something other then one row something very bad
@@ -961 +964 @@
             my $query = $db->prepare_cached( $sql->delete_object );
             my $rows = $query->execute( $so_id );
+            $query->finish;
 
             # if we affected something other then two rows something very bad

trunk/Nebulous/lib/Nebulous/Server.pm

@@ -1 +1 @@
 # Copyright (c) 2004  Joshua Hoblitt
 #
-# $Id: Server.pm,v 1.45 2007-05-09 00:45:21 jhoblitt Exp $
+# $Id: Server.pm,v 1.46 2008-01-23 00:46:06 jhoblitt Exp $
 
 package Nebulous::Server;
@@ -928 +928 @@
 
             unless ( $rows > 0 ) {
+                $query->finish;
                 $log->logdie( "no instance is associated with uri" );
             }
@@ -933 +934 @@
             $so_id = $query->fetchrow_hashref->{ 'so_id' };
             $query->finish;
+
         }
 
@@ -947 +949 @@
             my $query = $db->prepare_cached( $sql->delete_instance );
             my $rows = $query->execute( $uri );
+            $query->finish;
             
             # if we affected something other then one row something very bad
@@ -961 +964 @@
             my $query = $db->prepare_cached( $sql->delete_object );
             my $rows = $query->execute( $so_id );
+            $query->finish;
 
             # if we affected something other then two rows something very bad