Changeset 15647

Timestamp:

Nov 18, 2007, 6:26:12 PM (18 years ago)

Author:

eugene

Message:

updates for compression

Location:

trunk/Ohana/src

Files:

• libfits/include/gfitsio.h (modified) (1 diff)
• libfits/matrix/F_compress_M.c (modified) (3 diffs)
• opihi/cmd.data/rd.c (modified) (1 diff)

trunk/Ohana/src/libfits/include/gfitsio.h

@@ -152 +152 @@
 void    gfits_set_matrix_value         PROTO((Matrix *matrix, int x, int y, double value)); 
 int     gfits_write_matrix             PROTO((char *filename, Matrix *matrix)); 
-int     gfits_uncompress_image         PROTO((Header *header, Matrix *matrix, FTable *ftable, int primary));
+int     gfits_uncompress_image         PROTO((Header *header, Matrix *matrix, FTable *ftable));
 int     gfits_uncompress_data          PROTO((char *zdata, int Nzdata, char *cmptype, char **optname, char **optvalue, int Nopt, char *outdata, int *Nout, int out_pixsize));
 int     gfits_distribute_data          PROTO((Matrix *matrix, int bitpix, char *data, int Ndata, int *otile, int *ztile, float zscale, float zzero));

trunk/Ohana/src/libfits/matrix/F_compress_M.c

@@ -28 +28 @@
   return (FALSE); }
 
-int gfits_uncompress_image (Header *header, Matrix *matrix, FTable *ftable, int primary) {
+int gfits_uncompress_image (Header *header, Matrix *matrix, FTable *ftable) {
 
   int i, j, status, zimage, zcol, Nzrows, Nout, Nzdata, max_tile_size, bytes_per_pixel;
@@ -103 +103 @@
   // XXX is Noptions set to the correct value?
   // XXX get ZMASKCMP 
-  // XXX can primary be defined on basis of the header?
-
-  if (primary) {
-    // XXX SIMPLE & XTENSION need to be set on the first line
-    if (!gfits_scan (header, "ZSIMPLE", "%t", 1, &header->simple)) ESCAPE;
+
+  int zsimple, have_zsimple;
+  int have_ztension;
+
+  have_zsimple  = gfits_scan (header, "ZSIMPLE", "%t", 1, &zsimple);
+  have_ztension = gfits_scan (header, "ZTENSION", "%s", 1, exttype);
+
+  if (!have_zsimple && !have_ztension) ESCAPE;
+  if ( have_zsimple &&  have_ztension) ESCAPE;
+
+  // have_zsimple : image comes from a PHU
+  if (have_zsimple) {
+    header->simple = zsimple;
     gfits_delete (header, "ZSIMPLE", 1);
     gfits_extended_to_primary (header, header->simple, "Image data");
@@ -114 +122 @@
     MOD_KEYWORD ("ZBLOCKED", "BLOCKED",  "%t", &header->extend, header->extend);
   } else {
-    // XXX XTENSION needs to be set on the first line
-    if (!gfits_scan (header, "ZTENSION", "%s", 1, exttype)) ESCAPE;
     gfits_delete (header, "ZTENSION", 1);
     gfits_modify_extended (header, exttype, "Image extension");
+    // XXX validate that exttype == 'IMAGE'?
 
     MOD_KEYWORD ("ZPCOUNT",  "PCOUNT",   "%d", &header->pcount, header->pcount);

trunk/Ohana/src/opihi/cmd.data/rd.c

@@ -182 +182 @@
     ftable.header = &theader;
     gfits_copy_header (&buf[0].header, ftable.header);
-    status = gfits_fread_ftable_data (f, &ftable);  // XXX does this do more than read the bytes?
-    status = gfits_uncompress_image (&buf[0].header, &buf[0].matrix, &ftable, !(ccdsel || extend));
+    status = gfits_fread_ftable_data (f, &ftable);  // this just reads the bytes (not even a SWAP)
+    status = gfits_uncompress_image (&buf[0].header, &buf[0].matrix, &ftable);
     gfits_free_table (&ftable);
     // XXX this currently does not work for a cube (we get a cube back, not a specific plane)